Engine: Add Support for ERB trimming#841
Merged
Merged
Conversation
marcoroth
force-pushed
the
engine-trim
branch
from
9bfe4e5 to
6fa9fe2
Compare
marcoroth
force-pushed
the
engine-trim
branch
from
6fa9fe2 to
e48f32b
Compare
marcoroth
added a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements support for left trimming
<%-and right trimming-%>in theHerb::Engine. This should now more closely match the compiled templateErubi::Engineproduces and renders.Resolves #649
Enables #650